Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds readers for schema headers and footers #271

Merged
merged 1 commit into from
May 31, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

#256

Description of changes:

  • Adds readers for headers and footers, and tests.

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from desaikd May 27, 2023 00:12
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 96.72% and project coverage change: +0.40 🎉

Comparison is base (f32fca9) 83.19% compared to head (00e1a88) 83.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   83.19%   83.59%   +0.40%     
==========================================
  Files         131      133       +2     
  Lines        3201     3262      +61     
  Branches      756      768      +12     
==========================================
+ Hits         2663     2727      +64     
+ Misses        311      306       -5     
- Partials      227      229       +2     
Impacted Files Coverage Δ
...m/amazon/ionschema/reader/internal/HeaderReader.kt 96.29% <96.29%> (ø)
...m/amazon/ionschema/reader/internal/FooterReader.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@popematt popematt merged commit 63aba66 into amazon-ion:master May 31, 2023
@popematt popematt deleted the read-header-footer branch May 31, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants