Add unrestricted mode #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting with showImpliedEdges. motivated by desire to add config for unrestricted diagramming mode.
generic edge type for use with unrestricted editing
should help with trying out new node/edge types, without needing to modify schema until it's known to be useful. allows adding node as parent or child of any other node. future will probably allow something like editing edge labels, or adding custom nodes.
explore/claim nodes shouldn't need this kind of experimentation, and this makes the add node button group less overwhelming with options
using a separate column rather than loosening the existing column seems ideal because then we can still have strict typing in most places, and the custom-ness is called out explicitly where it's needed.
only in unrestricted editing mode
performance was a bit slow with a lot of nodes and unrestricted editing. add node button group shouldn't need to re-render ever anyway
when refreshing playground or switching topics, it seems nice to remember these settings
"island" meaning nodes that aren't connected by any path
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197
Description of changes
Additional context