fix: deleting node does not delete edge's claims #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously was deleting the part's claim tree, but not claim trees for related parts also being deleted, e.g. edges tied to a node being deleted. now all invalid claim trees will be deleted. seems easier to do this than to track specifically which trees need to be deleted.
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
keyserj
deleted the
fix-deleting-part-doesnt-delete-dependent-claims-scores
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously was deleting the part's claim tree, but not claim trees for related parts also being deleted, e.g. edges tied to a node being deleted.
now all invalid claim trees will be deleted. seems easier to do this than to track specifically which trees need to be deleted.