Post discourse small improvements #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
had feedback that highlighted edges weren't standing out enough. includes creating our own marker for flow, and removing `markerStart` from edge, since our rendering can choose the marker (rather than an edge's data).
easy now that we're creating our own markers
keyserj
force-pushed
the
post-discourse-small-improvements
branch
from
7d037c5 to
5ee0081
Compare
Using the new prop on relation rather then separate list. Needed so that effects could have `creates` relation in one direction and `createdBy` relation in the other. Also includes: - remove unused edge-to-edge support from relations - remove adding parent solution to problem because it seems like you wouldn't really add "createdBy" that way. - remove "problem created by effect" because "effect creates detriment" replaces that.
i.e. adding effect/benefit/detriments to each other in either direction.
keyserj
force-pushed
the
post-discourse-small-improvements
branch
from
5ee0081 to
48ce1eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Additional context