Landing touchups #654
Merged
Landing touchups #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ameliorate-docs canceled.
|
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
keyserj
force-pushed
the
landing-touchups
branch
from
85b3ba5 to
028dbd0
Compare
quick views and perspectives seem more cool
the cards don't seem as cool as the features
can see how this feels. generally it seems like it's ok to add a little more clutter to the details pane, for the benefit of having a way to expose new users to indicators.
this property often didn't want to be with the view e.g. viewX (like viewJustification) want to preserve the selected node, while changing the rest of the view state. e.g. selecting/unselected node should not be a view change, should not trigger "changed filter" event, should not be undone/redone when using that navigation buttons... the main use case was to allow saving selection with a quick view. short-term we can add ?selected to URL for this, long-term we can add `selectedState` to `views` table, with a "save selected state?" option (similar to what we'll want for perspectives).
can keep an eye on how it feels. seems a little awkward because it takes up a whole row in the pane, but trying to fit it on the same row as the content's title seemed challenging to design without it looking even more awkward.
keyserj
force-pushed
the
landing-touchups
branch
from
c9901ae to
f19526f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Additional context