Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use semver for @babel/eslint-parser #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Jan 9, 2025

Description

Use a semver range for @babel/eslint-parser.

Please make sure that the PR fulfills these requirements

  • I checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • Rule changes includes a comment to describe the reasoning behind the change.
  • PR contains a single rule change.

Motivation and Context

When this was added in #94, a fixed version was used rather than a semver. There is no rationale for this in the PR, so I assume this was a mistake.

As a result, every consuming package has a fixed version:

$ npm ls @babel/eslint-parser
...
└─┬ [email protected]
  └── @babel/[email protected]

@babel/[email protected] is required to support eslint@9 so this is part of #132

How Has This Been Tested?

Packed and verified version in consumers is no longer fixed.

$ npm ls @babel/eslint-parser
...
└─┬ [email protected]
  └── @babel/[email protected]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant