Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parrot-friendly): make parrot-graphql an optional peer dep #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Jan 17, 2025

Description

Move parrot-graphql to be an optional peer dep of parrot-friendly.

Motivation and Context

parrot-graphql is the only dependency of parrot-friendly and adds a lot of dependencies. If you don't use the graphql support, this is a bit of a waste.

├─┬ [email protected]
│ └─┬ [email protected]
│   ├─┬ [email protected]
│   │ ├─┬ [email protected]
│   │ │ ├── [email protected] deduped
│   │ │ ├── [email protected] deduped
│   │ │ ├─┬ [email protected]
│   │ │ │ └── [email protected]
│   │ │ ├── [email protected]
│   │ │ └─┬ [email protected]
│   │ │   ├── [email protected]
│   │ │   └── [email protected]
│   │ ├─┬ [email protected]
│   │ │ ├─┬ @wry/[email protected]
│   │ │ │ └── [email protected]
│   │ │ ├── [email protected] deduped
│   │ │ ├── [email protected] deduped
│   │ │ ├── [email protected] deduped
│   │ │ └── [email protected]
│   │ ├── [email protected]
│   │ ├── [email protected] deduped
│   │ ├── [email protected]
│   │ └── [email protected]
│   └─┬ [email protected]
│     └── [email protected] deduped

Is this a breaking change?

How Has This Been Tested?

Packed and installed parrot-friendly and verified that the graphql deps no longer are listed, and that parrot-friendly still works as expected.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

@smackfu smackfu requested a review from a team as a code owner January 17, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant