-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve model handling speed #31
Conversation
@flferretti there are many conflicts after #34 and #35. Do you want to port the changes over the future main? Otherwise I can take care of it since I was the one that introduced all the conflicts. |
I can handle that, thank you! |
b3d595e
to
8d6da11
Compare
8d6da11
to
c4e35b1
Compare
c4e35b1
to
c6ccc60
Compare
Ready for review @diegoferigo, I also fixed a minor typo here rod/src/rod/utils/frame_convention.py Line 297 in 11d2768
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost good, I have only a doubt on a possible change of behavior.
833f1f9
to
bdaf332
Compare
Co-authored-by: Diego Ferigo <[email protected]>
bdaf332
to
f19d41c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond the suggestion below that somehow got lost, this PR looks good thanks! We can finalize the type hints migration with list
, dict
, set
, |None
, etc in the future.
This pull request includes several code improvements and bug fixes. Here is a summary of the changes:
utf-8
encoding when reading from files (Avoids file read error in Windows)Benchmarks:
C.C. @diegoferigo