Sample initial levels with replacement (surprising to find this bug a…

…fter 24 years)
amices · Aug 23, 2024 · 30e7661 · 30e7661
1 parent bd4efd1
commit 30e7661
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# mice 3.16.14
+
+* Fixes a bug during initialization of factor values
+
 # mice 3.16.13
 
 * Adds support for the `literanger` package for `rf` imputation that is about twice as fast as `ranger` (#648). Thanks @stephematician for the contribution.

diff --git a/R/initialize.imp.R b/R/initialize.imp.R
@@ -18,7 +18,7 @@ initialize.imp <- function(data, m, ignore, where, blocks, visitSequence,
             imp[[j]][, i] <- data.init[wy, j]
           } else {
             if (is.factor(y)) {
-              imp[[j]][, i] <- sample(levels(y), nrow(data))
+              imp[[j]][, i] <- sample(levels(y), nrow(data), replace = TRUE)
             } else {
               imp[[j]][, i] <- rnorm(nrow(data))
             }