fix: offline directly after receive bad url error

amplitude · Jan 31, 2025 · 3998f3f · 3998f3f
1 parent bcd4a44
commit 3998f3f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Sources/Amplitude/Utilities/EventPipeline.swift b/Sources/Amplitude/Utilities/EventPipeline.swift
@@ -12,8 +12,8 @@ public class EventPipeline {
     let storage: Storage?
     let logger: (any Logger)?
     let configuration: Configuration
-    var maxRetryInterval: TimeInterval = 60
-    var maxRetryCount: Int = 6
+    let maxRetryInterval: TimeInterval = 60
+    let maxRetryCount: Int = 6
 
     @Atomic internal var eventCount: Int = 0
     internal var flushTimer: QueueTimer?
@@ -119,7 +119,7 @@ public class EventPipeline {
                         self.currentUpload = nil
                     }
                     self.configuration.offline = true
-                    self.logger?.log(message: "Request failed more than \(self.maxRetryCount) times, marking offline")
+                    self.logger?.error(message: "Request failed more than \(self.maxRetryCount) times, marking offline")
                 } else {
                     // Don't send the next event file if we're being deallocated
                     let nextFileBlock: () -> Void = { [weak self] in
@@ -135,7 +135,7 @@ public class EventPipeline {
                     } else {
                         let sendingInterval = min(self.maxRetryInterval, pow(2, Double(failures - 1)))
                         self.uploadsQueue.asyncAfter(deadline: .now() + sendingInterval, execute: nextFileBlock)
-                        self.logger?.debug(message: "Request failed \(failures) times, send next event file in \(sendingInterval) seconds")
+                        self.logger?.error(message: "Request failed \(failures) times, send next event file in \(sendingInterval) seconds")
                     }
                 }
             }

diff --git a/Sources/Amplitude/Utilities/HttpClient.swift b/Sources/Amplitude/Utilities/HttpClient.swift
@@ -45,7 +45,7 @@ class HttpClient {
                         let nsError = error as NSError
                         if nsError.domain == NSURLErrorDomain {
                             switch nsError.code {
-                            case NSURLErrorCannotConnectToHost, NSURLErrorNetworkConnectionLost, NSURLErrorCannotFindHost, NSURLErrorAppTransportSecurityRequiresSecureConnection, NSURLErrorNotConnectedToInternet:
+                            case NSURLErrorCannotConnectToHost, NSURLErrorNetworkConnectionLost, NSURLErrorCannotFindHost, NSURLErrorAppTransportSecurityRequiresSecureConnection, NSURLErrorNotConnectedToInternet, NSURLErrorBadURL:
                                 logger?.error(message: "Conection failed with error: \(error.localizedDescription), marking offline")
                                 configuration.offline = true
                             default: