fixes

Signed-off-by: Kristen Armes <[email protected]>
amundsen-io · Apr 4, 2024 · 6a75856 · 6a75856
1 parent acdf8d1
commit 6a75856
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/databuilder/setup.py b/databuilder/setup.py
@@ -63,7 +63,7 @@
     'Flask==1.0.2',
     'gremlinpython==3.4.3',
     'requests-aws4auth==1.1.0',
-    'typing-extensions==4.0.0',
+    'typing-extensions==4.1.0',
     'overrides==2.5',
     'boto3==1.17.23'
 ]

diff --git a/frontend/amundsen_application/base/base_bigquery_preview_client.py b/frontend/amundsen_application/base/base_bigquery_preview_client.py
@@ -82,7 +82,7 @@ def get_preview_data(self, params: Dict, optionalHeaders: Optional[Dict] = None)
             )
 
     def get_feature_preview_data(self, params: Dict, optionalHeaders: Optional[Dict] = None) -> Response:
-        return make_response(jsonify({'preview_data': {}}), HTTPStatus.OK)
+        pass
 
 
 class Encoder(json.JSONEncoder):

diff --git a/frontend/amundsen_application/base/base_redash_preview_client.py b/frontend/amundsen_application/base/base_redash_preview_client.py
@@ -271,4 +271,4 @@ def get_preview_data(self, params: Dict, optionalHeaders: Optional[Dict] = None)
             return make_response(jsonify({'preview_data': {}}), HTTPStatus.INTERNAL_SERVER_ERROR)
 
     def get_feature_preview_data(self, params: Dict, optionalHeaders: Optional[Dict] = None) -> FlaskResponse:
-        return make_response(jsonify({'preview_data': {}}), HTTPStatus.OK)
+        pass
diff --git a/frontend/amundsen_application/base/base_s3_preview_client.py b/frontend/amundsen_application/base/base_s3_preview_client.py
@@ -45,4 +45,4 @@ def get_feature_preview_data(self, params: Dict, optionalHeaders: Optional[Dict]
         BaseS3PreviewClient only supports data preview currently but this function needs to be stubbed to
         implement the BasePreviewClient interface
         """
-        return make_response(jsonify({'preview_data': {}}), HTTPStatus.OK)
+        pass
diff --git a/frontend/amundsen_application/base/base_superset_preview_client.py b/frontend/amundsen_application/base/base_superset_preview_client.py
@@ -59,4 +59,4 @@ def get_preview_data(self, params: Dict, optionalHeaders: Optional[Dict] = None)
             return make_response(jsonify({'preview_data': {}}), HTTPStatus.INTERNAL_SERVER_ERROR)
 
     def get_feature_preview_data(self, params: Dict, optionalHeaders: Optional[Dict] = None) -> FlaskResponse:
-        return make_response(jsonify({'preview_data': {}}), HTTPStatus.OK)
+        pass
diff --git a/metadata/tests/unit/proxy/fixtures/atlas_test_data.py b/metadata/tests/unit/proxy/fixtures/atlas_test_data.py
@@ -44,14 +44,14 @@ class Data:
                 {'attributes': {
                     'stat_name': 'max',
                     'stat_val': 100.1234,
-                    'start_epoch': '100',
-                    'end_epoch': '200',
+                    'start_epoch': 100,
+                    'end_epoch': 200,
                 }},
                 {'attributes': {
                     'stat_name': 'min',
                     'stat_val': 0.5678,
-                    'start_epoch': '100',
-                    'end_epoch': '200',
+                    'start_epoch': 100,
+                    'end_epoch': 200,
                 }},
             ]
         },
@@ -74,23 +74,23 @@ class Data:
         {'attributes': {
             'stat_name': 'max',
             'stat_val': '100.1234',
-            'start_epoch': '100',
-            'end_epoch': '200',
+            'start_epoch': 100,
+            'end_epoch': 200,
         }},
         {'attributes': {
             'stat_name': 'min',
             'stat_val': '0.5678',
-            'start_epoch': '100',
-            'end_epoch': '200',
+            'start_epoch': 100,
+            'end_epoch': 200,
         }},
     ]
 
     test_exp_col_stats_formatted = [
         {'attributes': {
             'stat_name': 'minimum',
             'stat_val': '0.57',
-            'start_epoch': '100',
-            'end_epoch': '200',
+            'start_epoch': 100,
+            'end_epoch': 200,
         }},
     ]
-Original file line number
+Diff line change
@@ Expand Up @@
                 )
         def get_feature_preview_data(self, params: Dict, optionalHeaders: Optional[Dict] = None) -> Response:
-            return make_response(jsonify({'preview_data': {}}), HTTPStatus.OK)
+            pass
     class Encoder(json.JSONEncoder):
@@ Expand Down @@