Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade sqlalchemy in frontend to latest 1.x.x version #2246

Merged
merged 2 commits into from
Apr 11, 2024
Merged

chore: Upgrade sqlalchemy in frontend to latest 1.x.x version #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d2c855
Upgrade sqlalchemy in frontend
kristenarmes Apr 11, 2024
f2738b5
Fix test
kristenarmes Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/amundsen_application/base/examples/example_announcement_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
try:
from sqlalchemy import Column, Integer, String, DateTime, create_engine
from sqlalchemy.ext.declarative import declarative_base
from sqlalchemy.inspection import inspect
from sqlalchemy.orm import sessionmaker
except ModuleNotFoundError:
pass
Expand Down Expand Up @@ -37,7 +38,7 @@ def _setup_mysql(self) -> None:
session = sessionmaker(bind=self.engine)()

# add dummy announcements to preview
if not self.engine.dialect.has_table(self.engine, DBAnnouncement.__tablename__):
if not inspect(self.engine).has_table(DBAnnouncement.__tablename__):
Base.metadata.create_all(self.engine)

announcements = []
Expand Down
2 changes: 1 addition & 1 deletion frontend/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SPDX-License-Identifier: Apache-2.0

responses==0.12.1
SQLAlchemy==1.3.23
SQLAlchemy==1.4.52
retrying>=1.3.3,<2.0

# Backport of PEP 557, Data Classes for Python 3.6.
Expand Down
Loading