Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd attempt on Dockerhub CI #152

Merged
merged 1 commit into from
May 10, 2019
Merged

2nd attempt on Dockerhub CI #152

merged 1 commit into from
May 10, 2019

Conversation

jinhyukchang
Copy link
Contributor

Summary of Changes

2nd attempt of #150

Tests

Same as #150

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide
  • I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

@jinhyukchang jinhyukchang requested a review from feng-tao May 10, 2019 21:19
@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   53.13%   53.13%           
=======================================
  Files         106      106           
  Lines        2650     2650           
  Branches      273      273           
=======================================
  Hits         1408     1408           
  Misses       1213     1213           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cddc82...2f17359. Read the comment docs.

@jinhyukchang jinhyukchang merged commit d82faad into master May 10, 2019
@feng-tao feng-tao deleted the jinchang-travis-1 branch May 11, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants