Disable broken -DTOOLBOX so we can pass in CXXFLAGS from the environment #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main SeBa
Makefile
as well as several otherMakefiles
add-DTOOLBOX
toCXXFLAGS
. This flag seems to enable some extra code when applied.Unfortunately that code is broken in various ways, causing compile errors. When compiling SeBa, this is hidden because the recursion in the Makefiles isn't implemented in the usual way, so that
CXXFLAGS
isn't passed on recursive calls, so that the flag gets dropped again on the way down, and is never actually applied.If
CXXFLAGS
is set by the user, perhaps because they want to specify some more optimisation flags or because they're trying to make a package, the behaviour ofmake
changes, andCXXFLAGS
is passed down the line. As a result, the code is compiled with-DTOOLBOX
in that case, and compilation fails.It seems that this issue has been around for a long time, and that probably the code enabled by
-DTOOLBOX
isn't really used by anyone. I don't have time to fix it, but I would like to get rid of the weird work-around that AMUSE currently has to do to get SeBa to compile. So I'm submitting this PR that removes-DTOOLBOX
from the Makefiles, so that I can compile normally and also pass the extraCXXFLAGS
that I need when packaging.