Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patch_files.py for mpiamrvac #1016

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update patch_files.py for mpiamrvac #1016

merged 1 commit into from
Dec 6, 2023

Conversation

rieder
Copy link
Member

@rieder rieder commented Dec 6, 2023

No description provided.

@rieder rieder requested a review from a team as a code owner December 6, 2023 11:13
@rieder rieder merged commit 03c0bb5 into main Dec 6, 2023
4 of 6 checks passed
@rieder rieder deleted the rieder-patch-1 branch December 6, 2023 11:13
@LourensVeen
Copy link
Collaborator

FWIW, if you'd called the commit Reformat patch_files.py for mpiamrvac it would have been immediately clear what this does. Makes it easier for other developers to follow along, or for people rooting around the git history later.

@rieder
Copy link
Member Author

rieder commented Dec 6, 2023

that's part of the update, but there was a bugfix in there too (line 43, convert to str).
I admit, better to separate those...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rieder @LourensVeen