Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing hldeger binary in docker image #272

Closed
wants to merge 1 commit into from

Conversation

azzamsa
Copy link
Contributor

@azzamsa azzamsa commented Aug 19, 2024

The hledger binary is not included in the docker image. Thus Paisa will complain of missing binary if we choose to use hleger as ledger cli

@azzamsa
Copy link
Contributor Author

azzamsa commented Aug 19, 2024

Until this PR gets merged, this is my work around.

FROM docker.io/ananthakumaran/paisa:latest

# Add hledger binary to the image
RUN apk --no-cache add hledger

# Set the working directory
WORKDIR /root/

# Define the entry point
CMD ["paisa", "serve"]

@ananthakumaran
Copy link
Owner

I didn't add it to the docker image to keep the size of the image small. Can you check the size of the new image and post it here. I am more worried about someone asking the same for beancount which will pull in the entire python dependency.

@azzamsa
Copy link
Contributor Author

azzamsa commented Aug 19, 2024

REPOSITORY                      TAG       IMAGE ID       CREATED        SIZE
paisa                           mine      509796ae9ae1   9 hours ago    109MB

You can add this step as a guide somewhere in the wiki/doc, but it is a pain for non-developers to follow.

. I am more worried about someone asking the same for beancount which will pull in the entire Python dependency.

Or we can just add a suffix similar to debian-slim. So we will have:

  • paisa:latest (ledger)
  • paisa-hledger:latest
  • paisa-beanaccount:latest

@ananthakumaran
Copy link
Owner

ananthakumaran commented Aug 20, 2024

I prefer the second approach, one image per binary and paisa-all with all the binaries (specially useful for pikapods)

@azzamsa azzamsa mentioned this pull request Aug 20, 2024
@azzamsa
Copy link
Contributor Author

azzamsa commented Aug 20, 2024

@ananthakumaran what do you think of #274 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants