chore: mock file age in python units #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_create_listing behaves differently on listings that are older than 120 days. Change these tests to mock the file age calculation, rather than just making the files newers. Signed-off-by: Will Murphy <[email protected]>
wagoodman
approved these changes
Dec 11, 2023
willmurphyscode
added
the
changelog-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_create_listing behaves differently on listings that are older than 120 days. Change these tests to mock the file age calculation, rather than just making the files newer.
See #209 (comment)
It would also be possible to change the datestamps in all the fixture JSON and recompute the expected checksums, but that work would have to be repeated every 4 months.