Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classifier for Drupal #2449

Closed
wants to merge 1 commit into from
Closed

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

Signed-off-by: Laurent Goderre <[email protected]>
@willmurphyscode
Copy link
Contributor

Hi @LaurentGoderre, thanks very much for the PR!

Syft already has PHP cataloging defined over at https://github.com/anchore/syft/tree/main/syft/pkg/cataloger/php, and it seems to find Drupal:

syft -q drupal:latest | rg '^drupal'
drupal/core                                                          10.1.7                          php-composer
drupal/core-composer-scaffold                                        10.1.7                          php-composer
drupal/core-project-message                                          10.1.7                          php-composer
drupal/core-recommended                                              10.1.7                          php-composer

Do you have an example of an image or repo with drupal in it that syft doesn't detect? Or is there something else you were trying to fix?

@LaurentGoderre
Copy link
Contributor Author

@willmurphyscode I was unsure if detecting the parts was enough to encapsulate the whole application.

@LaurentGoderre
Copy link
Contributor Author

@willmurphyscode I just double check and confirmed these packages cover the whole app.

@neufeind
Copy link

neufeind commented Mar 8, 2024

But it only finds php-applications installed through composer (looking for composer.lock). That's in general a best-practice these days. But especially in webhosting-environments you might still find installations not necessarily installed through composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants