Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIT - Notificaciones: log #1964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CIT - Notificaciones: log #1964

wants to merge 1 commit into from

Conversation

JuanIRamirez
Copy link
Contributor

Requerimiento

https://proyectos.andes.gob.ar/browse/MISC-369

Funcionalidad desarrollada

  1. Se modificó ../turnosController.ts para que no genere notificacionesLog.error cuando:
    • El turno es 'delDia'
    • Turnos programados.
  2. Se quitó método verificarPrestacion().
  3. Se quitó método telefonoUnico().

UserStories llegó a completarse

  • Si
  • No

Requiere actualizaciones en la base de datos

  • Si
  • No

@JuanIRamirez JuanIRamirez requested review from a team as code owners September 25, 2024 12:09
@aldoEMatamala aldoEMatamala force-pushed the MISC-369 branch 2 times, most recently from 3c2eb5e to c545bd5 Compare November 7, 2024 18:56
@MCele
Copy link
Contributor

MCele commented Nov 20, 2024

console.log() detected

Copy link
Contributor

@negro89 negro89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juancho, dejé un par de observaciones. Recordar borrar los console.log y el codigo comentado (linea 224)

if (prestacion) {
console.log(prestacion);
const registro = prestacion.ejecucion?.registros?.find(x => x.valor?.informe !== null);
turno.actividad = registro.valor?.informe?.tipoActividad?.term;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay alguna posibilidad de que no se encuentre el registro? en ese caso "undefined.valor" va a dar error. Quizas agregar un "?" en cada ocurrencia o bien consultar si registro tiene contenido.

Por otro lado, agregaría un try-catch adentro del bucle para que no corte toda la ejecución en caso de error.

@negro89 negro89 added the changes requested Se solicitaron cambios label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Se solicitaron cambios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants