-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FEAT) ABM de restricción por paciente #68
base: master
Are you sure you want to change the base?
Conversation
1f12806
to
a9ce6ac
Compare
Assignee: Juan Ramirez2 ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OBSERVACIONES:
- Se duplicó el componente paciente-buscar (no debería). Queda pendiente corregir esto y ver que queden funcionando bien todas las referencias a ambos componentes.
- La foto de los usuarios en el listado no debería aparecer.
@@ -0,0 +1,7 @@ | |||
export interface IContacto { | |||
tipo: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Como tipo hace referencia a "celular, fijo o email" se puede cambiar su declaración por string en vez de any
@@ -0,0 +1,84 @@ | |||
import { IUbicacion } from './IUbicacion'; | |||
// import { IMatricula } from './IMatricula'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remover comentario!
inicio: Date; | ||
baja: { | ||
motivo: String; | ||
fecha: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cambiar any por Date
@@ -0,0 +1,8 @@ | |||
// import { IPacienteMatch } from '../interfaces/IPacienteMatch.inteface'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminar comentario
|
||
export interface PacienteBuscarResultado { | ||
err: any; | ||
pacientes: any[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Como es un array de pacientes se puede remplazar por Ipaciente[]
interface PacienteEscaneado { | ||
documento: string; | ||
apellido: string; | ||
nombre: string; | ||
sexo: string; | ||
fechaNacimiento: Date; | ||
scan: string; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si esta interfaz no se utiliza entonces eliminarla.
// import { NombrePipe } from '../pipes/nombre.pipe'; | ||
// import { EdadPipe } from '../pipes/edad.pipe'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminar estas lineas de código!
/** | ||
* RegEx para validar nombres y apellidos. | ||
*/ | ||
public nombreRegEx = /^[a-zA-ZàáèéìíòóùúüñÀÁÈÉÌÍÒÓÙÚÑ']+( [a-zA-ZZàáèéìíòóùúüñÀÁÈÉÌÍÒÓÙÚÑ']+)*$/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parece que esta expresión regular no se estaría usando en ningún lugar.
// organizaciones(): Observable<any> { | ||
// return this.server.get('/modules/gestor-usuarios/organizaciones', {}).pipe( | ||
// cacheStorage({ key: 'organizaciones-permisos' }) | ||
// ); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminar lineas de código comentadas
* Metodo post. Inserta un nuevo profesional | ||
* @param {IProfesional} profesional | ||
*/ | ||
// post(profesional: IProfesional): Observable<IProfesional> { | ||
// return this.server.post(this.profesionalUrl, profesional); // ...using post request | ||
// } | ||
|
||
// saveFirma(firma) { | ||
// return this.post(firma); | ||
// } | ||
|
||
// saveProfesional(profesionalModel: any) { | ||
// return profesionalModel.id ? this.server.patch(`${this.profesionalUrl}/${profesionalModel.id}`, profesionalModel) : this.server.post(this.profesionalUrl, { profesional: profesionalModel }); | ||
// } | ||
|
||
// validarProfesional(body): Observable<any> { | ||
// return this.server.post(this.profesionalUrl + '/validar', body); | ||
// } | ||
|
||
// actualizarProfesional(body, options?: Options): Observable<any> { | ||
// return this.server.put(this.profesionalUrl + '/actualizar', body, options); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminar estas lineas de codigo comentadas al igual que la linea 5.
Assignee: Juan Ramirez2
ready
Requerimiento
https://proyectos.andes.gob.ar/browse/MONIT-60
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion