Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVENTS: carga de recursos desde colección #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juuliotero
Copy link
Contributor

Se modifica la carga de recursos para que busque directamente por nombre de colección.

@juuliotero juuliotero force-pushed the fix-recursos branch 5 times, most recently from 0ebc961 to fced057 Compare July 1, 2020 12:12
Copy link

@sychus sychus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El código parece correcto. Faltaría hacerle un test funcional por si las moscas

if (req.query.search) {
query = { nombre: { $regex: req.query.search, $options: 'i' } }
}
mongoose.connection.db.collection(recurso, (err, collection) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utilizar async/await para la conexión

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corregido

@juuliotero juuliotero force-pushed the fix-recursos branch 3 times, most recently from 17af03b to 535a02d Compare July 13, 2020 15:34
@juuliotero juuliotero requested a review from condorpiedra July 28, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants