Do not create thread if tests_per_worker==1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-segalini
force-pushed
the
one-thread
branch
from
d4cc9d4 to
0a7617e
Compare
cjriches
reviewed
Feb 13, 2024
pytest_parallel/__init__.py
Outdated
| import pickle | ||
| import sys | ||
|
|
||
| self.errors.put(('name', pickle.dumps(sys.exc_info()))) |
There was a problem hiding this comment.
We seem to have lost a name variable here - should that be passed in?
Avoid creating a thread when there is one worker. This allows benefitting from signal-based communication with the test workers when threads are not used (e.g., for timeouts as in solves kevlened#96)
andrea-segalini
force-pushed
the
one-thread
branch
from
0a7617e to
ad62dce
Compare
cjriches
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating a thread when there is one worker. This allows benefitting from signal-based communication with the test workers when threads are not used (e.g., for timeouts as in solves kevlened#96)