Added new collage layout #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey and thanks for your contribution. Another solution which I need to improve can be found here andi34#108 |
|
Hi, I changed the files lib/configsetup.inc.php and config/config.inc.php so the options which where deleted by accident are in the files again. |
2 tasks
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody,
it took me a while but now I found some time to implement a second collage layout as desribed in issue "New Collage Layout #164"
Therefore I did the following changes:
• added a new checkbox in lib/configsetup.inc.php with the following options: '2x2' and'2x4'
• added the default layout in config/config.inc.php ('2x2', the currently existing layout)
• changed the code of lib/collage.php so the layout parameter is input value of a switch/case statement.
The case '2x2' is the old existing code of the collage. Everything in case '2x4' I added.
I tested the code on my raspberry pi 4B and it worked well.
Hope the code is good enough to be pulled. Php is totally new for me. I normally work with C and Python ;)