fix url_converter.py using greedy regex to find URLs #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url_converters uses a greedy regex to find URLs, and can cause incorrect output. Here is a simple test case:
Note the stray double-quote character in
media(min-width: 768px")
.This happens because the repetition quantifier in the regex used is greedy, and runs all the way up until the very last ')' in the file. The solution is to use a lazy quantifier, which runs to the first ')' that it sees.
Note that this is an incomplete fix - regex is not suitable for parsing CSS, and this regex cannot parse things like:
url("file_\"with\"quotes_in_name.png")
orurl("file (Copy).png")
For that, a real parser would be needed.