Use Glob in PUT file paths and Allow for Multi File Upload #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin99d
changed the title
andrusha
reviewed
Jan 21, 2024
andrusha
reviewed
Jan 24, 2024
andrusha
reviewed
Jan 24, 2024
andrusha
reviewed
Feb 7, 2024
|
FYI: Until the limit to concurrency is implemented this PR is not ready for review. I am more than happy for your comments. But please know some of this code is stuff I plan to clean on my own (right now this is all being coded while I am on planes and busses). |
|
@andrusha besides the two questions I had this PR is good to go. I decided to create a way for the user to define the file size and concurrency thresholds. Let me know your thoughts! |
Use spawn blocking for computationally intensive glob traverse Use async tokio fs for metadata fetching Move all PUT query logic into put.rs file Delete files feature for now
Спасибо! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, I would be very thankful for any feedback.
By adding the GLOB package, file paths like the one below are now allowed:
api.exec(&format!("PUT file://{} @%OSCAR_AGE_MALE;", "/Users/colin/test-snowflake/data/*.csv"))This PR uses Tokio tasks to manage spawn a thread for each individual file.
This PR also moves libraries only required for the PUT command into the
filefeature