linting testing

andychenbruce · Mar 11, 2024 · d60423a · d60423a
1 parent 2b5eae5
commit d60423a
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 12 deletions.
diff --git a/.github/workflows/npm.yml → .github/workflows/react.yml b/.github/workflows/npm.yml → .github/workflows/react.yml
@@ -18,10 +18,13 @@ jobs:
     - uses: actions/checkout@v3
     - name: Install
       working-directory: ./frontend
-      run: npm install
+      run: yarn install
+    - name: Lint
+      working-directory: ./frontend
+      run: yarn eslint src
     # - name: Format
     #   working-directory: ./frontend
-    #   run: npx prettier --check ./
+    #   run: yarn prettier --check ./
     - name: Build
       working-directory: ./frontend
-      run: npm run build
+      run: yarn run build
diff --git a/frontend/src/backend_interface.ts b/frontend/src/backend_interface.ts
@@ -65,7 +65,7 @@ export interface EditCard {
   access_token: AccessToken;
   deck_id: number;
   card_index: number;
-  new_question: String;
+  new_question: string;
   new_answer: string;
 }
 

diff --git a/frontend/src/pages/acc_create/index.tsx b/frontend/src/pages/acc_create/index.tsx
@@ -38,7 +38,7 @@ const Main: React.FC<PageProps> = () => {
       setPasswordMismatch(true);
       return;
     }
-    let new_user_request: NewUser = {
+    const new_user_request: NewUser = {
       user_name: user.username,
       email: user.email,
       password: user.password1,

diff --git a/frontend/src/pages/ai_test/index.tsx b/frontend/src/pages/ai_test/index.tsx
@@ -13,7 +13,7 @@ const App: React.FC = () => {
       prompt: prompt,
     };
     send_json_backend(ENDPOINT_AI_TEST, JSON.stringify(aiSend))
-      .then((data: any) => {
+      .then((data: string) => {
         const responseData = JSON.parse(data);
         setResponse(responseData.content);
       })

diff --git a/frontend/src/pages/deck_manage/index.tsx b/frontend/src/pages/deck_manage/index.tsx
@@ -166,22 +166,22 @@ const App: React.FC = () => {
 
   const handleIconSelectionConfirm = () => {
 
-    let temp_deck_id = currentEditing
+    const temp_deck_id = currentEditing
     if (temp_deck_id == null){
       console.error('deck_id is null')
       return;
     }
-    let access_token = get_session_token();
+    const access_token = get_session_token();
     if (access_token == null) {
       return;
     }
-    let index = selectedIcon
+    const index = selectedIcon
     if (index === null) {
       console.error('No icon selected');
       changeIconErrorSnackbar(true)
       return;
     } 
-    let new_icon: SetDeckIcon = {
+    const new_icon: SetDeckIcon = {
       access_token: access_token,
       deck_id: temp_deck_id,
       icon: index,
@@ -206,7 +206,7 @@ const App: React.FC = () => {
     setSelectedIcon(index);
   };
 
-  const handleEditDeckIcon = (_deckId: number) => {
+  const handleEditDeckIcon = () => {
     setOpenIconDialog(true);
   };
 
@@ -485,7 +485,7 @@ const App: React.FC = () => {
 
               <IconButton
                 onClick={() => {
-                  handleEditDeckIcon(deck.deck_id);
+                  handleEditDeckIcon();
                   setCurrentEditing(deck.deck_id);
                 }}