cancel method added #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not quite...the cancel method is for individual report ids, not report suites. https://github.com/randyzwitch/RSiteCatalyst/blob/master/R/CancelReport.R I wouldn't worry about iterating over multiple report ids, in most cases you can't act quick enough to actually cancel a report. I can't think of a time where I've actually used this method for anything other than testing that it theoretically works! |
|
Fixed the conflict, and I think I got it right. Let me know! Andy |
This reverts commit 254120b.
|
Yes, this appears correct. I reverted your .gitignore change, which was causing the merge conflict. That can be re-added in a different commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to add the cancel method, looks like rsid_list is what we're creating..maybe I should only have one rsid at a time? Let me know your thoughts.