Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing navigation issues #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixing navigation issues #3

wants to merge 1 commit into from

Conversation

shayanbagchi
Copy link

@shayanbagchi shayanbagchi commented Jul 22, 2018

hey aneagoie!
there is this bug in your code i.e when you click the "signout" button it takes you to the registration page, well ideally it should take you to the "signin" page.
so, i fixed the code adding another if-else statement.

Hope, you'll approve it.
Thanks....

@T3N4K4
Copy link

T3N4K4 commented Sep 19, 2018

A little note on that.
You change onRouteChange to onRoutechange.
This should be fixed in this pull as this will break the code in Signin.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants