Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WGL Core Test #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RobertBColton
Copy link

I've updated the test to try creating a real actual core context using the appropriate WGL extension. I am unsure and forget if epoxy_has_gl_extension can check for WGL extensions, so I could use some help with what to replace that with if needed.

Attempt to create an actual core context using WGL extension.
@ebassi
Copy link
Collaborator

ebassi commented Jul 21, 2020

You should use epoxy_has_wgl_extension() to check for a WGL extension.

@RobertBColton
Copy link
Author

Done!

@ebassi
Copy link
Collaborator

ebassi commented Jul 21, 2020

Thanks for your patience. This looks good to me; it would be great to have a Windows CI pipeline to verify it, but I think it's kind of complicated to do with the spotty GL support on Windows…

@RobertBColton
Copy link
Author

I think there may be a small problem though because I now see that lighting is tested in here... but lighting is fixed-function pipeline and not in the 3.1 or newer contexts. You can get them with the compatibility context though. Not sure what is appropriate, to only try the lighting enable if the core context creation failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants