-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix static build (DllMain) #266
base: master
Are you sure you want to change the base?
Conversation
Do *not* include the `DllMain` entry point in the static build, only when it's a shared build.
@ebassi Maybe you want to look at this PR? |
I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on. |
It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress. |
I understand, no blame.
I agree. I guess, we can extend the github action workflow file with a static build: |
Ping? (sorry to just bother you, otherwise I don't see this getting merged) |
Any feedback? |
I would appreciate if this is supported upstream as well. |
Is it really enough to not compile DllMain? Wouldn't it take an alternative way to do the initialization which is in the body of this function? |
Do not include the
DllMain
entry point in the static build, only when it's a shared build.