Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static build (DllMain) #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

melroy89
Copy link

@melroy89 melroy89 commented Dec 6, 2021

Do not include the DllMain entry point in the static build, only when it's a shared build.

Do *not* include the `DllMain` entry point in the static build, only when it's a shared build.
@melroy89 melroy89 mentioned this pull request Dec 6, 2021
10 tasks
@melroy89
Copy link
Author

@ebassi Maybe you want to look at this PR?

@ebassi
Copy link
Collaborator

ebassi commented Dec 10, 2021

I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on.

@ebassi
Copy link
Collaborator

ebassi commented Dec 10, 2021

It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress.

@melroy89
Copy link
Author

I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on.

I understand, no blame.

It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress.

I agree. I guess, we can extend the github action workflow file with a static build:
https://github.com/anholt/libepoxy/blob/master/.github/workflows/msys2.yml

@melroy89
Copy link
Author

Ping? (sorry to just bother you, otherwise I don't see this getting merged)

@melroy89
Copy link
Author

melroy89 commented Mar 2, 2022

Any feedback?

@theartful
Copy link

I would appreciate if this is supported upstream as well.

@melroy89
Copy link
Author

melroy89 commented Jun 3, 2022

I would appreciate if this is supported upstream as well.

Me too that is why I created this pr. @ebassi @anholt somebody?

@dg0yt
Copy link

dg0yt commented Jul 2, 2023

Is it really enough to not compile DllMain? Wouldn't it take an alternative way to do the initialization which is in the body of this function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants