Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also compress key on iOS when fallback secure environment is used #18

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

berendsliedrecht
Copy link
Member

Signed-off-by: Berend Sliedrecht [email protected]

Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to check or fallback env, so do we just always compress? Does it still work with secure enclave?

@berendsliedrecht
Copy link
Member Author

This doesn't seem to check or fallback env, so do we just always compress? Does it still work with secure enclave?

We always return a compressed key. This does not care about the source of the key, just about the format and change it. Which IMO is the correct way as the fallback could provide any key format (spki, uncompressed and compressed).

@berendsliedrecht berendsliedrecht merged commit a822967 into main Nov 22, 2024
2 checks passed
@berendsliedrecht berendsliedrecht deleted the ios-compress-key branch November 22, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants