Bugfix for #63 invalid arguments retrieving info for some prs (#75)

* Add config for app issue-branch-name * Some comments are attached to the file and have not reference/selection in the content. Need to be removed. Fixes #63 --------- Co-authored-by: Ankit Sinha <[email protected]>
ankitbko · Jan 8, 2024 · 3a80875 · 3a80875
1 parent 2f4aacd
commit 3a80875
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.github/issue-branch.yml b/.github/issue-branch.yml
@@ -0,0 +1,9 @@
+branchName: full
+silent: false
+autoCloseIssue: true
+
+branches:
+  - label: enhancement
+    prefix: feature/
+  - label: bug
+    prefix: bugfix/
diff --git a/src/view/treeNodes/fileChangeNode.ts b/src/view/treeNodes/fileChangeNode.ts
@@ -166,14 +166,16 @@ export class FileChangeNode extends TreeNode implements vscode.TreeItem {
 
 	updateShowOptions() {
 		const reviewThreads = this.pullRequest.reviewThreadsCache;
-		const reviewThreadsForNode = reviewThreads.filter(thread => !thread.isDeleted && thread.path === this.fileName);
+		let reviewThreadsForNode = reviewThreads.filter(thread => !thread.isDeleted && thread.path === this.fileName);
 
 		DecorationProvider.updateFileComments(
 			this.resourceUri,
 			this.pullRequest.getPullRequestId(),
 			this.fileName,
 			reviewThreadsForNode.length > 0,
 		);
+		/* Some comments are attached to the file and have not reference/selection in the content. Need to be removed here. */
+		reviewThreadsForNode = reviewThreadsForNode.filter((thread) => thread.line !== undefined);
 
 		if (reviewThreadsForNode.length) {
 			reviewThreadsForNode.sort((a, b) => a.line - b.line);