-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deck Options #250
Update Deck Options #250
Conversation
Which ones specifically? Also: Is this PR still a work in progress, or are you submitting it for review now? |
Draft means I'm still working on it. You can still add comments though.
I already fixed this. So no need for issue tracker. |
That's why I asked -- because that's exactly what I'm trying to avoid. Reviewing incomplete PRs is a waste of time. If there's something significant and specific you need to consult on before your PR is final -- a draft PR might make sense. Is the question you asked about the links the only thing outstanding, and otherwise your work is done? |
I'm still going through everything. It's not done yet. The draft allows other people to know what I'm doing and optionally comment on it if they want. Expertium will want to see what I do in FSRS section. |
src/deck-options.md
Outdated
the question side should be played when replaying the audio while an answer is | ||
shown. Please note that it does not control what happens when you show the | ||
- **Skip question when replaying answer**: Controls whether audio from | ||
the question side should be played when replaying the audio while on answer side. Please note that it does not control what happens when you show the | ||
answer; for that please see [this section](templates/fields.md#special-fields). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anybody knows what is this cross-referencing? I didn't find anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this on point? Replay is controlled with that Deck Options setting -- initial-play is controlled on the template.
FrontSide will not automatically play any audio that was on the front side of the card. If you wish to have the same audio play automatically on both the front and back of the card, you’ll need to manually include the audio fields on the back as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thrown into some unfamiliar section; didn't even noticed that line. I changed this to:
Controls whether audio from the question side is played when you use replay action on the answer side. Note that, Anki does not automatically play audio from the {{FrontSide}} field. This option does not influence the behaviour of automatic play.
Got it. 👍🏽 I'll wait until you submit it for review. |
Co-authored-by: Damien Elmes <[email protected]>
Co-authored-by: Damien Elmes <[email protected]>
Co-authored-by: Damien Elmes <[email protected]>
Co-authored-by: Damien Elmes <[email protected]> Co-authored-by: Expertium <[email protected]>
|
My vote is to stick with "scheduler", for what it matters |
You mean "SM-2 scheduler" and "FSRS scheduler"? |
@Expertium I did, I did! Last month on your Reddit thread:
|
@brishtibheja It's pretty dismissive to refer to others editing your copy as "bikeshedding" -- or perhaps you and I don't have the same understanding of that term. But, I think that Damien's point is probably a better place to put our focus -- #250 (comment) . This PR is probably just too big. In the future, even if an entire page needs an update, "do one thing" is still the best guideline to follow. |
It came up some time ago in discord, but I keep using that word wrong. I agree with you and dae. This was too huge. I think this is in a mergeable form now, so I'll follow up with another PR with formatting changes, etc. @dae is there anything left to do here? Think it should be good to go now. |
|
|
Yeah, but unless Dae is fervently against linking to FAQ from Deck Options, I'd like to do so. Same reasoning - improving discoverability, so that users have an easier time finding all the relevant links and info. |
https://faqs.ankiweb.net/frequently-asked-questions-about-fsrs.html @brishtibheja please add this to deck options. Something like "Several frequently asked questions about FSRS have been answered here" |
Thanks for all the hard work that went into this. No objections to linking to the FAQ. Can't remember if I mentioned it elsewhere already, but I actually think we might be better off consolidating all info into the manual in the long run - the separate FAQ page was mainly a convenience for support in the past. |
(I won't hold up the PR with that change as it's been waiting long enough; follow-up welcome) |
There are links to very old forum posts, mostly outdated, what do we do about them?