Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore exception raised by pip_system_certs not found #3114

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Ignore exception raised by pip_system_certs not found #3114

merged 1 commit into from
Apr 5, 2024

Conversation

escape0707
Copy link
Contributor

Close #3113

This dependency usually doesn't benefit Linux distros with requests library configured to use system certificate already. And is not packaged by most distros. Making it optional will make most Linux users' installation much easier.

@escape0707 escape0707 changed the title Ignore except raised by pip_system_certs not found Ignore exception raised by pip_system_certs not found Apr 4, 2024
@escape0707
Copy link
Contributor Author

Maybe requirements.aqt.in should be changed too, if all Linux distros don't need this dependency? I'm not sure about that, tho.

@dae
Copy link
Member

dae commented Apr 4, 2024

Thank you for the change. I think this is fine, but we should probably print a message to stdout in the exception case - something like "pip_system_certs not installed; custom SSL certs may not work".

Distros probably need to make up their own mind about the .in/.txt files - either patching it out or using their own dependency list.

@escape0707
Copy link
Contributor Author

we should probably print a message to stdout in the exception case - something like "pip_system_certs not installed; custom SSL certs may not work".

Great advice, I'll change the code to print that asap.

Distros probably need to make up their own mind about the .in/.txt files - either patching it out or using their own dependency list.

I think maybe packagers who actually make packages out of source code building should have greater say than me. So I'll leave the judge to them.

This dependency usually doesn't benefit Linux distros with requests library configured to use system certificate already. And is not packaged by most distros. Making it optional will make most Linux users' installation much easier.
@dae dae merged commit 97efd49 into ankitects:main Apr 5, 2024
1 check failed
@dae
Copy link
Member

dae commented Apr 5, 2024

Thank you!

@escape0707 escape0707 deleted the patch-1 branch April 5, 2024 19:39
dae pushed a commit that referenced this pull request Apr 11, 2024
This dependency usually doesn't benefit Linux distros with requests library configured to use system certificate already. And is not packaged by most distros. Making it optional will make most Linux users' installation much easier.

(cherry picked from commit 97efd49)
@lalala-233 lalala-233 mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anki gives ModuleNotFoundError without pip_system_certs installed
2 participants