-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make App Data a Map in RM Library #1740
Open
agureev
wants to merge
32
commits into
base
Choose a base branch
from
artem/nock-rm-sets
base: base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agureev
commented
Dec 30, 2024
•
edited
Loading
edited
- Change Nock stdlib Action datatype to have maps instead of binary for app data
- Implement set to_noun and from_noun functionality
- Change the Elixir Actions datatype accordingly
Some of the tests use actual Juvix-compiled code. This can break for several reasons and hence should be usually skipped. They need to remain, however, so that we can update the files once Juvix compilation comes in-sync with Node.
Previously the Mug Elixir codebase used was simply a murmur3 hash with fixed seed. Now it is properly implemented.
agureev
added
execution stdlib
Deals with the standard library for Nock
nock
Deals with the nock VM Environment (interpretation, jam, cue etc.)
breaking
labels
Dec 30, 2024
IMPORTANT: We need to take care when merging this to coordinate with Juvix as this is potentially a breaking change. |
agureev
force-pushed
the
artem/nock-rm-sets
branch
from
January 3, 2025 13:27
53d05fb
to
d7e7e14
Compare
Previously mug computations relied on logics cores and disallowed any compile-time mug computations due to 9 calls. Fixes this by introducing a local nock4k evaluator which we use instead, i.e. skipping the jet calls.
Moves standard library and Jet Registry information outside the Nock module into own separate modules.
Now mugs can be computed rather than hard-coded. Only need to change the arm positions if needed.
Previously layer location for ENock-used arms were hardcoded. So if we were increasing the layer of the stdlib, we had to change all the arms in the examples. This commit fixes this, making all arms compute things automatically.
Make the `prove_squared_small` use an input which is encoded by another (private) example
Now Kind is computed as a sha256-d jam of a [label logic] cell
We should be fine with not converting the computations to integers unless needed.
…m/nock-stdlib-mug
Introduce a mug layer in standar library, including all ordering functionality.
Changes Nockma StandardLib strings for new layer. Warning: Breaks Juvix-compiled tests
Adds a module for Elixir implementations of mor, gor, dor noun ordering functionality.
Adds a helper function to translate booleans into Nock booleans.
Adds jets for dor, mor, gor
Adds jets for gor, mor, dor
Add a layer for supporting sets and set operations, the `in` door in particular
…' into artem/nock-rm-sets
Now App data actually contains information.
Implement to_noun and from_noun for set structures.
agureev
force-pushed
the
artem/nock-rm-sets
branch
from
January 6, 2025 12:12
d7e7e14
to
8d102e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
execution stdlib
Deals with the standard library for Nock
nock
Deals with the nock VM Environment (interpretation, jam, cue etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.