Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ibc-rs to v0.57 #4247

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Upgrade ibc-rs to v0.57 #4247

wants to merge 9 commits into from

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jan 17, 2025

Describe your changes

NOTE: Need to update ibc-middleware with the release version

Mainly updated error types of ibc-rs. No logic should be changed.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 53.25843% with 208 lines in your changes missing coverage. Please review.

Project coverage is 74.06%. Comparing base (48fbbf1) to head (759fcfc).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/context/common.rs 56.56% 43 Missing ⚠️
crates/ibc/src/context/nft_transfer.rs 55.78% 42 Missing ⚠️
crates/ibc/src/lib.rs 9.67% 28 Missing ⚠️
crates/ibc/src/context/client.rs 0.00% 18 Missing ⚠️
crates/ibc/src/context/token_transfer.rs 75.00% 17 Missing ⚠️
crates/ibc/src/context/execution.rs 63.15% 14 Missing ⚠️
crates/ibc/src/context/nft_transfer_mod.rs 13.33% 13 Missing ⚠️
crates/ibc/src/context/validation.rs 72.50% 11 Missing ⚠️
crates/ibc/src/context/middlewares/pfm_mod.rs 0.00% 5 Missing ⚠️
crates/ibc/src/event.rs 0.00% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4247    +/-   ##
========================================
  Coverage   74.05%   74.06%            
========================================
  Files         345      345            
  Lines      110033   110193   +160     
========================================
+ Hits        81489    81611   +122     
- Misses      28544    28582    +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88 yito88 force-pushed the yuji/upgrade-ibc-rs branch from 7f5345e to 544dc98 Compare January 23, 2025 16:44
@yito88 yito88 force-pushed the yuji/upgrade-ibc-rs branch from 544dc98 to 3d916f2 Compare January 30, 2025 10:14
@yito88 yito88 marked this pull request as ready for review January 30, 2025 10:26
@yito88 yito88 requested a review from sug0 January 30, 2025 11:49
@yito88 yito88 requested a review from batconjurer January 30, 2025 11:50
clippy.toml Show resolved Hide resolved
clippy.toml Show resolved Hide resolved
crates/tests/src/e2e/setup.rs Outdated Show resolved Hide resolved
@tzemanovic
Copy link
Member

I've added a commit to switch to the published ibc-middleware crates

@tzemanovic tzemanovic added the backport-libs-0.47 Backport libraries to 0.47 maintenance branch label Feb 3, 2025
@sug0 sug0 self-requested a review February 3, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.47 Backport libraries to 0.47 maintenance branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants