Skip to content

Commit

Permalink
Merge pull request monero-project#994
Browse files Browse the repository at this point in the history
79948db CMake: side-step Clang (CMake?) bug for Release build (anonimal)
ec33da0 CMake: set AppleClang detection and min version (anonimal)
  • Loading branch information
anonimal committed Jul 27, 2018
2 parents a6faac5 + 79948db commit a172c47
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,19 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
message(FATAL_ERROR "Clang 3.5 or higher is required")
endif()
set(CLANG TRUE)
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 8.0.0)
message(FATAL_ERROR "AppleClang 8.0.0 or higher is required")
endif()
set(CLANG TRUE)
endif()

# TODO(unassigned): an absolute hack to work around a clang (CMake?) bug that does not like our Release build type.
# Strangely, we don't do anything out of the ordinary with our Release build type, nor do our deps.
# The issue is not reproducible with Debug build type. See #993.
# Absolutely resolve this hack when are out of out Alpha, or no later than Beta.
if (CLANG)
set(CMAKE_BUILD_TYPE Debug)
endif()

# Require C++14 support (minimum version compilers guarantee this)
Expand Down

0 comments on commit a172c47

Please sign in to comment.