-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios_line: Initiale commit to create the module ios_line
#918
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
==========================================
+ Coverage 86.90% 87.03% +0.13%
==========================================
Files 193 203 +10
Lines 11904 12384 +480
==========================================
+ Hits 10345 10779 +434
- Misses 1559 1605 +46 |
ios_service
ios_line
f02692a
to
d4da016
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 46s |
9d43c7c
to
aa956fc
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 34s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 55s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 09s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 10s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 39s |
Hey @earendilfr, we would be actively reviewing this PR and plan to merge it in future releases. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 04s |
Hey @KB-perByte, currently, it seems working fine from my point of view concerning this module. And I will also perform a PR on the repo https://github.com/ansible-network/resource_module_models top add this module too. |
@earendilfr There needs to be some integration tests here, covering bare minimum functionality of the PR. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 41s |
532bfab
to
f8e64f4
Compare
OK: I have added some integration tests. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 56s |
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
Allow to take in count the case where the ACL should be put for the VRF
- Fixe the config module to: - doesn't modify lines not indicated with the deleted and replaced profiles - take correctly in case the case where we have aux line present on device
98fa10a
to
9cebfa1
Compare
for more information, see https://pre-commit.ci
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
This module has been tested on: - Cisco IOS-XE 17.06.05
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Need to force to resend the command `terminal length 0` in this case
for more information, see https://pre-commit.ci
Allow to take in count the case where the ACL should be put for the VRF
- Fixe the config module to: - doesn't modify lines not indicated with the deleted and replaced profiles - take correctly in case the case where we have aux line present on device
for more information, see https://pre-commit.ci
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 44s |
This module has been tested on:
SUMMARY
Add a new module
ios_line
to configure the lines part of Cisco IOS devices.Currently, only line console and line vty are managed
ISSUE TYPE
COMPONENT NAME
ios_line
ADDITIONAL INFORMATION
The current module configure all the line console and vty.
It take in count the case that:
line console 0
line vty
between 0 and 4