-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_query: returns execution_time_ms list containing execution time per query #697
mysql_query: returns execution_time_ms list containing execution time per query #697
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 79.43% 77.05% -2.38%
==========================================
Files 32 20 -12
Lines 2815 2672 -143
Branches 703 678 -25
==========================================
- Hits 2236 2059 -177
- Misses 397 415 +18
- Partials 182 198 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ready for review |
Nice addition @Andersson007. I think this is ready. I'm surprised this feature is not described in DB API 2.0 (PEP 249). Otherwise PyMySQL could have take care of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one question about line 159.
Since tests only checks if the returned value is bigger than 0, we never check what's returned.
Co-authored-by: Laurent Indermühle <[email protected]>
@laurent-indermuehle your suggestion has been committed, also answered the question |
960ac32
into
ansible-collections:main
@markuman @laurent-indermuehle thanks for reviewing! |
SUMMARY
Was requested for c.postgresql and I think it'd be nice to have this here too