Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced file permission hardening #360

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Enhanced file permission hardening #360

merged 4 commits into from
Dec 13, 2024

Conversation

lakrass
Copy link
Contributor

@lakrass lakrass commented Dec 12, 2024 •
edited
Loading

  • more strict file permissions for existing paths
  • implemented some missing file perm hardenings
  • implemented deletion of unused files when installing Vault via repo
  • use private folder for tls keys when hardening is enabled

Perms are based on HashiCorps hardening guide: https://developer.hashicorp.com/vault/docs/concepts/production-hardening

@lakrass lakrass changed the title Enhanced production hardening Enhanced file permission hardening Dec 12, 2024
@lakrass
Copy link
Contributor Author

lakrass commented Dec 12, 2024 •
edited
Loading

This PR is ready for review!

@lakrass
Copy link
Contributor Author

lakrass commented Dec 12, 2024

fixes #265

@FalcoSuessgott
Copy link
Collaborator

can u rebase please

@FalcoSuessgott
Copy link
Collaborator

Squash and add a Conventional commit and then we can merge :)
https://www.conventionalcommits.org/en/v1.0.0/

@lakrass lakrass force-pushed the enhanced-production-hardening branch 3 times, most recently from 889771c to 0c7195c Compare December 12, 2024 23:35
@lakrass lakrass force-pushed the enhanced-production-hardening branch from 0c7195c to eaa03db Compare December 12, 2024 23:41
@lakrass
Copy link
Contributor Author

lakrass commented Dec 12, 2024 •
edited
Loading

I messed up my rebase on the first run. I rebuilt my branch on top of the master by squashing & cherry-picking and switched to conventional commits.

This should hopefully now be mergeable :)

@FalcoSuessgott FalcoSuessgott merged commit 09d9789 into ansible-community:master Dec 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lakrass @FalcoSuessgott