Merge PR #60 into devel

This change fixes flaky SEGFAULTs in `pylibsshext.channel.Channel.exec_command()`.
ansible · Jun 12, 2020 · 129c040 · 129c040
2 parents 184e4d2 + a56356e
commit 129c040
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/pylibsshext/includes/callbacks.pxd b/src/pylibsshext/includes/callbacks.pxd
@@ -19,7 +19,7 @@ from libc.stdint cimport uint32_t
 
 from pylibsshext.includes.libssh cimport ssh_session, ssh_channel
 
-cdef extern from "libssh/callbacks.h" nogil:
+cdef extern from "libssh/callbacks.h":
 
     void ssh_callbacks_init(void *)
 

diff --git a/tests/unit/channel_test.py b/tests/unit/channel_test.py
@@ -22,11 +22,6 @@ def ssh_channel(ssh_client_session):
         chan.close()
 
 
-@pytest.mark.xfail(
-    reason='This test causes SEGFAULT, flakily.',
-    run=False,
-    strict=False,
-)
 @pytest.mark.forked
 def test_exec_command(ssh_channel):
     """Test getting the output of a remotely executed command."""