Skip to content

Commit

Permalink
REFACTOR: Angle property getter in aedt 2023.2 and below is broken in…
Browse files Browse the repository at this point in the history
… GRPC and has to be bypassed. (#4867)

Co-authored-by: maxcapodi78 <Shark78>
  • Loading branch information
maxcapodi78 authored Jul 3, 2024
1 parent 4afb56b commit 08386d3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion _unittest/test_21_Circuit.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ def test_38_browse_log_file(self):
for i in range(10):
f.write("L{} net_{} net_{} 1e-9\n".format(i, i, i + 1))
f.write("C{} net_{} 0 5e-12\n".format(i, i + 1))
self.aedtapp.modeler.components.create_interface_port("net_0", (0, 0))
self.aedtapp.modeler.components.create_interface_port("net_0", (0, 0), angle=90)
self.aedtapp.modeler.components.create_interface_port("net_10", (0.01, 0))
lna = self.aedtapp.create_setup("mylna", self.aedtapp.SETUPS.NexximLNA)
lna.props["SweepDefinition"]["Data"] = "LINC 0Hz 1GHz 101"
Expand Down
8 changes: 7 additions & 1 deletion pyaedt/modeler/circuits/object3dcircuit.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
from pyaedt.generic.general_methods import _arg2dict
from pyaedt.generic.general_methods import _dim_arg
from pyaedt.generic.general_methods import pyaedt_function_handler
from pyaedt.generic.settings import settings
from pyaedt.modeler.cad.elements3d import _dict2arg
from pyaedt.modeler.geometry_operators import GeometryOperators as go

Expand Down Expand Up @@ -681,12 +682,17 @@ def angle(self):
if "Angle=" in info:
self._angle = float(info[6:])
break
else:
elif settings.aedt_version > "2023.2":
self._angle = float(
self._oeditor.GetPropertyValue("BaseElementTab", self.composed_name, "Component Angle").replace(
"deg", ""
)
)
else: # pragma: no cover
self._circuit_components._app.logger.warning(
"Angles are not supported by gRPC in AEDT versions lower than 2024 R1."
)

return self._angle

@angle.setter
Expand Down

0 comments on commit 08386d3

Please sign in to comment.