Skip to content

Commit

Permalink
FIX: Do not use mutable arguments in method signatures. (#4493)
Browse files Browse the repository at this point in the history
  • Loading branch information
@MaxJPRey
MaxJPRey authored Apr 13, 2024
1 parent 15d8dcd commit 5660dbb
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 11 deletions.
13 changes: 10 additions & 3 deletions pyaedt/modeler/circuits/PrimitivesCircuit.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def add_pin_iports(self, name, id_num):
return True

@pyaedt_function_handler()
def create_interface_port(self, name, location=[], angle=0):
def create_interface_port(self, name, location=None, angle=0):
"""Create an interface port.
Parameters
Expand All @@ -255,6 +255,9 @@ def create_interface_port(self, name, location=[], angle=0):
>>> oEditor.CreateIPort
"""
if location is None:
location = []

if name in self._app.excitations:
self.logger.warning("Port name already assigned.")
return False
Expand Down Expand Up @@ -633,7 +636,7 @@ def _parse_ports_name(file, num_terminal):
def create_touchstone_component(
self,
model_name,
location=[],
location=None,
angle=0,
show_bitmap=True,
):
Expand Down Expand Up @@ -673,6 +676,8 @@ def create_touchstone_component(
>>> s_parameter_path = os.path.join("your_path", "s_param_file_name.s4p")
>>> circuit_comp = comps.create_touchstone_component(s_parameter_path, location=[0.0, 0.0], show_bitmap=False)
"""
if location is None:
location = []
xpos, ypos = self._get_location(location)
id = self.create_unique_id()
if os.path.exists(model_name):
Expand Down Expand Up @@ -1234,7 +1239,7 @@ def props(self):
return self._props

@pyaedt_function_handler()
def place(self, inst_name, location=[], angle=0, use_instance_id_netlist=False):
def place(self, inst_name, location=None, angle=0, use_instance_id_netlist=False):
"""Create a component from a library.
Parameters
Expand All @@ -1259,6 +1264,8 @@ def place(self, inst_name, location=[], angle=0, use_instance_id_netlist=False):
>>> oEditor.CreateComponent
"""
if location is None:
location = []
return self._component_manager.create_component(
inst_name=inst_name,
component_library=self.component_library,
Expand Down
8 changes: 6 additions & 2 deletions pyaedt/modeler/circuits/PrimitivesMaxwellCircuit.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def create_inductor(self, compname=None, value=50, location=None, angle=0, use_i
return id

@pyaedt_function_handler()
def create_capacitor(self, compname=None, value=50, location=[], angle=0, use_instance_id_netlist=False):
def create_capacitor(self, compname=None, value=50, location=None, angle=0, use_instance_id_netlist=False):
"""Create a capacitor.
Parameters
Expand All @@ -168,6 +168,8 @@ def create_capacitor(self, compname=None, value=50, location=[], angle=0, use_in
>>> oEditor.CreateComponent
"""
if location is None:
location = []
id = self.create_component(
compname,
component_library="Passive Elements",
Expand Down Expand Up @@ -222,7 +224,7 @@ def create_diode(self, compname=None, location=None, angle=0, use_instance_id_ne
return id

@pyaedt_function_handler()
def create_winding(self, compname=None, location=[], angle=0, use_instance_id_netlist=False):
def create_winding(self, compname=None, location=None, angle=0, use_instance_id_netlist=False):
"""Create an NPN transistor.
Parameters
Expand All @@ -246,6 +248,8 @@ def create_winding(self, compname=None, location=[], angle=0, use_instance_id_ne
>>> oEditor.CreateComponent
"""
if location is None:
location = []
id = self.create_component(
compname,
component_library="Dedicated Elements",
Expand Down
32 changes: 26 additions & 6 deletions pyaedt/modeler/circuits/PrimitivesNexxim.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ def create_resistor(self, compname=None, value=50, location=None, angle=0, use_i
return cmpid

@pyaedt_function_handler()
def create_inductor(self, compname=None, value=50, location=[], angle=0, use_instance_id_netlist=False):
def create_inductor(self, compname=None, value=50, location=None, angle=0, use_instance_id_netlist=False):
"""Create an inductor.
Parameters
Expand All @@ -665,6 +665,8 @@ def create_inductor(self, compname=None, value=50, location=[], angle=0, use_ins
>>> oEditor.CreateComponent
"""
if location is None:
location = []
cmpid = self.create_component(
compname,
component_library="Inductors",
Expand Down Expand Up @@ -809,7 +811,9 @@ def create_voltage_probe(self, probe_name=None, location=None, angle=0, use_inst
return cmpid

@pyaedt_function_handler()
def create_current_pulse(self, compname=None, value_lists=[], location=[], angle=0, use_instance_id_netlist=False):
def create_current_pulse(
self, compname=None, value_lists=None, location=None, angle=0, use_instance_id_netlist=False
):
"""Create a current pulse.
Parameters
Expand All @@ -836,6 +840,10 @@ def create_current_pulse(self, compname=None, value_lists=[], location=[], angle
>>> oEditor.CreateComponent
"""
if value_lists is None:
value_lists = []
if location is None:
location = []
cmpid = self.create_component(
compname,
component_library="Independent Sources",
Expand Down Expand Up @@ -863,7 +871,9 @@ def create_current_pulse(self, compname=None, value_lists=[], location=[], angle
return cmpid

@pyaedt_function_handler()
def create_voltage_pulse(self, compname=None, value_lists=[], location=[], angle=0, use_instance_id_netlist=False):
def create_voltage_pulse(
self, compname=None, value_lists=None, location=None, angle=0, use_instance_id_netlist=False
):
"""Create a voltage pulse.
Parameters
Expand All @@ -890,6 +900,10 @@ def create_voltage_pulse(self, compname=None, value_lists=[], location=[], angle
>>> oEditor.CreateComponent
"""
if value_lists is None:
value_lists = []
if location is None:
location = []
cmpid = self.create_component(
compname,
component_library="Independent Sources",
Expand Down Expand Up @@ -972,7 +986,7 @@ def create_voltage_pwl(
return cmpid

@pyaedt_function_handler()
def create_current_dc(self, compname=None, value=1, location=[], angle=0, use_instance_id_netlist=False):
def create_current_dc(self, compname=None, value=1, location=None, angle=0, use_instance_id_netlist=False):
"""Create a current DC source.
Parameters
Expand All @@ -999,6 +1013,8 @@ def create_current_dc(self, compname=None, value=1, location=[], angle=0, use_in
>>> oEditor.CreateComponent
"""
if location is None:
location = []
cmpid = self.create_component(
compname,
component_library="Independent Sources",
Expand Down Expand Up @@ -1062,7 +1078,7 @@ def create_coupling_inductors(
return cmpid

@pyaedt_function_handler()
def create_diode(self, compname=None, model_name="required", location=[], angle=0, use_instance_id_netlist=False):
def create_diode(self, compname=None, model_name="required", location=None, angle=0, use_instance_id_netlist=False):
"""Create a diode.
Parameters
Expand All @@ -1089,6 +1105,8 @@ def create_diode(self, compname=None, model_name="required", location=[], angle=
>>> oEditor.CreateComponent
"""
if location is None:
location = []
cmpid = self.create_component(
compname,
component_library="Diodes",
Expand Down Expand Up @@ -1144,7 +1162,7 @@ def create_npn(self, compname=None, value=None, location=None, angle=0, use_inst
return id

@pyaedt_function_handler()
def create_pnp(self, compname=None, value=50, location=[], angle=0, use_instance_id_netlist=False):
def create_pnp(self, compname=None, value=50, location=None, angle=0, use_instance_id_netlist=False):
"""Create a PNP transistor.
Parameters
Expand All @@ -1171,6 +1189,8 @@ def create_pnp(self, compname=None, value=50, location=[], angle=0, use_instance
>>> oEditor.CreateComponent
"""
if location is None:
location = []
id = self.create_component(
compname,
component_library="BJTs",
Expand Down

0 comments on commit 5660dbb

Please sign in to comment.