Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_intrinsics doesn't return correct values #5650

Closed
2 tasks done
gmalinve opened this issue Jan 13, 2025 · 0 comments · Fixed by #5652
Closed
2 tasks done

default_intrinsics doesn't return correct values #5650

gmalinve opened this issue Jan 13, 2025 · 0 comments · Fixed by #5652
Assignees
Labels
bug Something isn't working

Comments

@gmalinve
Copy link
Contributor

Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

Description of the bug

default_intrinsics doesn't return correct values.
In this specific case:

Image
I'd expect this to return both Freq and Phase values both only returns Phase.
This is due to the latest refactoring of props.
When code reaches this line:

 for i in self._app.design_solutions.intrinsics:
            if i == "Freq" and "Frequency" in self.props:

self.props is empty.
The check should be carried out on self.properties -> "Solution Freq".
Add a new elif check:

if i == "Freq" and "Solution Freq" in self.properties:
    intr[i] = self.properties["Solution Freq"]

Steps To Reproduce

Simply call:
hfss.setups[0].default_intrinsics

Which Operating System are you using?

Windows

Which Python version are you using?

3.8

Installed packages

all

@gmalinve gmalinve added the bug Something isn't working label Jan 13, 2025
@gmalinve gmalinve self-assigned this Jan 13, 2025
@gmalinve gmalinve linked a pull request Jan 13, 2025 that will close this issue
7 tasks
@gmalinve gmalinve mentioned this issue Jan 15, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant