-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: default intrinsics #5652
FIX: default intrinsics #5652
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5652 +/- ##
=======================================
Coverage 85.25% 85.26%
=======================================
Files 152 152
Lines 60944 60947 +3
=======================================
+ Hits 51960 51966 +6
+ Misses 8984 8981 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gmalinve If you are not going to fill the default description, could you please remove it and summarize the PR changes and add the associated issue in the description ? It helps for future maintenance :) |
Description
This default intrinsics weren't correctly populated for HFSS design since the latest refactoring of the GetDataModel PR.
Hence a new check for frequency was needed in properties.
Issue linked
Closes #5650
Checklist