Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: default intrinsics #5652

Merged
merged 4 commits into from
Jan 15, 2025
Merged

FIX: default intrinsics #5652

merged 4 commits into from
Jan 15, 2025

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Jan 13, 2025

Description

This default intrinsics weren't correctly populated for HFSS design since the latest refactoring of the GetDataModel PR.
Hence a new check for frequency was needed in properties.

Issue linked

Closes #5650

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this Jan 13, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Jan 13, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (334d730) to head (9947847).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5652   +/-   ##
=======================================
  Coverage   85.25%   85.26%           
=======================================
  Files         152      152           
  Lines       60944    60947    +3     
=======================================
+ Hits        51960    51966    +6     
+ Misses       8984     8981    -3     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys
Copy link
Collaborator

@gmalinve If you are not going to fill the default description, could you please remove it and summarize the PR changes and add the associated issue in the description ? It helps for future maintenance :)

@gmalinve gmalinve merged commit a2829c8 into main Jan 15, 2025
43 checks passed
@gmalinve gmalinve deleted the fix/default_intrinsics branch January 15, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_intrinsics doesn't return correct values
3 participants