Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check design type #3746

Merged
merged 2 commits into from
Oct 23, 2023
Merged

add check design type #3746

merged 2 commits into from
Oct 23, 2023

Conversation

gmalinve
Copy link
Contributor

No description provided.

@gmalinve gmalinve added the bug Something isn't working label Oct 12, 2023
@gmalinve gmalinve requested a review from tizianrot October 12, 2023 08:07
@gmalinve gmalinve self-assigned this Oct 12, 2023
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Oct 12, 2023 that may be closed by this pull request
Q2D doesn not create the Object Region - command ignored #3736
Closed
2 tasks
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3746 (7e8301c) into main (f8c7692) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3746   +/-   ##
=======================================
  Coverage   81.06%   81.07%           
=======================================
  Files         180      180           
  Lines       61961    61961           
=======================================
+ Hits        50230    50234    +4     
+ Misses      11731    11727    -4

maxcapodi78
maxcapodi78 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve
Copy link
Contributor Author

To be left open. @tizianrot will implement UT for Q2D.

MaxJPRey
MaxJPRey approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmalinve gmalinve merged commit ad12662 into main Oct 23, 2023
11 checks passed
@gmalinve gmalinve deleted the create_region_q2d branch October 23, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

@tizianrot tizianrot Awaiting requested review from tizianrot

Assignees

@gmalinve gmalinve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Q2D doesn not create the Object Region - command ignored
4 participants
@gmalinve @maxcapodi78 @MaxJPRey @tizianrot