Adds methods to set band start and stop frequencies, & corresponding unit tests #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3773 +/- ##
=======================================
Coverage 81.28% 81.29%
=======================================
Files 182 182
Lines 63008 63022 +14
=======================================
+ Hits 51218 51233 +15
+ Misses 11790 11789 -1 |
MaxJPRey
reviewed
Oct 20, 2023
jsalant22
reviewed
Oct 20, 2023
PipKat
reviewed
Oct 23, 2023
PipKat
reviewed
Oct 23, 2023
PipKat
reviewed
Oct 23, 2023
PipKat
reviewed
Oct 26, 2023
PipKat
reviewed
Oct 26, 2023
PipKat
reviewed
Oct 26, 2023
Co-authored-by: Kathy Pippert <[email protected]>
|
@zebanaqviWAT Please could you apply the suggested modifications. Thanks |
Co-authored-by: Kathy Pippert <[email protected]>
|
|
@zebanaqviWAT I reopened the this PR, in the comments you can see the suggested modifications you should make before merging this pull request to the main. |
|
@zebanaqviWAT If you applied the suggestions, you need to push "Resolve Conversation", and the codecov is failing, it means the unit test should improve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.