Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padstack name #3814

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _unittest/test_00_EDB.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ def test_020_components(self):
assert self.edbapp.components.components["R1"].pinlist
assert self.edbapp.components.components["R1"].pins
assert self.edbapp.components.components["R1"].pins["1"].pin_number
assert self.edbapp.components.components["R1"].pins["1"].name
self.edbapp.components.components["R1"].pins["1"].name = "1a"
assert self.edbapp.components.components["R1"].pins["1"].component
assert (
self.edbapp.components.components["R1"].pins["1"].lower_elevation
Expand Down
10 changes: 3 additions & 7 deletions pyaedt/edb_core/edb_data/padstacks_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -1455,13 +1455,8 @@

@property
def name(self):
"""Padstack Instance Name. If it is a pin, the syntax will be like in AEDT ComponentName-PinName."""
if self.is_pin:
comp_name = self._edb_padstackinstance.GetComponent().GetName()
pin_name = self._edb_padstackinstance.GetName()
return "-".join([comp_name, pin_name])
else:
return self._edb_padstackinstance.GetName()
"""Padstack instance name."""
return self._edb_padstackinstance.GetName()

Check warning on line 1459 in pyaedt/edb_core/edb_data/padstacks_data.py

View check run for this annotation

Codecov / codecov/patch

pyaedt/edb_core/edb_data/padstacks_data.py#L1459

Added line #L1459 was not covered by tests

@name.setter
def name(self, value):
Expand Down Expand Up @@ -1504,6 +1499,7 @@
@property
def pin_number(self):
"""Get pin number."""
warnings.warn("`pin_number` is deprecated. Use `name` property instead.", DeprecationWarning)

Check warning on line 1502 in pyaedt/edb_core/edb_data/padstacks_data.py

View check run for this annotation

Codecov / codecov/patch

pyaedt/edb_core/edb_data/padstacks_data.py#L1502

Added line #L1502 was not covered by tests
svandenb-dev marked this conversation as resolved.
Show resolved Hide resolved
return self._edb_padstackinstance.GetName()

@property
Expand Down
Loading