Emit license session #3856
Merged
Emit license session #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3856 +/- ##
==========================================
- Coverage 81.31% 81.30% -0.01%
==========================================
Files 182 182
Lines 63051 63054 +3
==========================================
+ Hits 51268 51269 +1
- Misses 11783 11785 +2 |
MaxJPRey
reviewed
Nov 8, 2023
…mit-license-session # Conflicts: # pyaedt/emit_core/results/revision.py
for more information, see https://pre-commit.ci
PipKat
reviewed
Nov 9, 2023
PipKat
reviewed
Nov 9, 2023
PipKat
reviewed
Nov 9, 2023
PipKat
reviewed
Nov 9, 2023
PipKat
reviewed
Nov 9, 2023
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
|
Thanks for the review @PipKat - I've applied your edits. |
|
[like] Kathy Pippert reacted to your message:
…________________________________
From: bryankaylor ***@***.***>
Sent: Thursday, November 9, 2023 3:47:30 PM
To: ansys/pyaedt ***@***.***>
Cc: Kathy Pippert ***@***.***>; Mention ***@***.***>
Subject: Re: [ansys/pyaedt] Emit license session (PR #3856)
[External Sender]
Thanks for the review @PipKat<https://github.com/PipKat> - I've applied your edits.
—
Reply to this email directly, view it on GitHub<#3856 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUHQY26TYLQBWR4FANAVU2TYDT3JFAVCNFSM6AAAAAA7DJBDOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGA4DENBYHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Alberto-DM
reviewed
Nov 16, 2023
…mit-license-session # Conflicts: # pyaedt/emit_core/results/revision.py
for more information, see https://pre-commit.ci
PipKat
reviewed
Nov 27, 2023
myoung301
reviewed
Nov 30, 2023
Samuelopez-ansys
approved these changes
Dec 1, 2023
|
@jsalant22 This branch was automatically merged after I approved it. Please check if everything is correct. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the EMIT API's new license_session object through pyaedt starting with 24R2.
Without it, when doing many runs, the license has to be checked in and out every time.
With it, the user controls when checkout and checkin happen and can do any number of runs between.
Also adds a new test verifying the license session is faster than individual runs for a test project.