Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring hfss3dlayout.py Class #4537

Merged
merged 10 commits into from
Apr 19, 2024
Merged

Refactoring hfss3dlayout.py Class #4537

merged 10 commits into from
Apr 19, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@maxcapodi78 maxcapodi78 added this to the v1.0 milestone Apr 18, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Samuelopez-ansys
Samuelopez-ansys previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.31579% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 34.39%. Comparing base (d574d5c) to head (678bae0).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4537       +/-   ##
===========================================
- Coverage   81.50%   34.39%   -47.11%     
===========================================
  Files         110      110               
  Lines       53731    53735        +4     
===========================================
- Hits        43794    18483    -25311     
- Misses       9937    35252    +25315

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) April 18, 2024 17:23
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Apr 18, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
Samuelopez-ansys
Samuelopez-ansys previously approved these changes Apr 19, 2024
View reviewed changes
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
pyaedt/hfss3dlayout.py Outdated Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys merged commit af932c3 into main Apr 19, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the hfss3dlayout_arguments branch April 19, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@gmalinve gmalinve Awaiting requested review from gmalinve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxcapodi78 @codecov-commenter @PipKat @Samuelopez-ansys